fix: don't output footnotes before their call sites #1566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a footnote has been output but we then decide to cancel the line it was output on, we should cancel the output of the footnote itself. This requires a bit of extra bookkeeping, so we know which footnotes are relevant, but otherwise largely works using the existing remove_placeholders code. Includes a minor refactor of footnote area management in LayoutContext, and a new testing utility: `tree_position`. Closes Kozea#1564.
|
I'm certainly conscious of the fact that this PR is one of the more wide-reaching ones I've submitted. Definitely feel free to push back on any parts of it if you'd like them done different ways: I'm trying to fit things into the conventions I've seen elsewhere in the code, but clearly I haven't seen everything. 😅 |
|
Thanks a lot for this pull request. It’s a very good idea to use |
aschmitz
added a commit
to aschmitz/WeasyPrint
that referenced
this pull request
Feb 14, 2022
This fixes a bug accidentally introduced in Kozea#1566, where we would try to unlayout a footnote that had not yet been laid out, if the algorithm decided that there would be insufficient space on a page before laying out a further footnote.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a footnote has been output but we then decide to cancel the line it was output on, we should cancel the output of the footnote itself.
This requires a bit of extra bookkeeping, so we know which footnotes are relevant, but otherwise largely works using the existing remove_placeholders code.
Includes a minor refactor of footnote area management in LayoutContext, and a new testing utility:
tree_position.Closes #1564.