Improve tests’ speed #1548
Merged
Improve tests’ speed #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Counter styles keys are strings, and values are dicts. These dicts are only created when new counters are created, but they are never modified, so there’s no need to deepcopy them. Tests are ~15% faster on my computer. We should get an interesting boost for very small documents too.
Related to #1457.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this pull request is to improve WeasyPrint’s speed, using tests for profiling. Tests are a good way to improve small documents’ rendering speed, as most of the unit tests render very small documents.
The main improvements of this pull request are:
This pull request saves between 10% and 20% of the total time spent in tests.