flexbox: initial attempt to add support for RTL direction #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liZe
requested changes
Oct 7, 2020
weasyprint/layout/flex.py
Outdated
| position_axis += free_space / len(line) / 2 | ||
| elif justify_content == 'space-evenly': | ||
| position_axis += free_space / (len(line) + 1) | ||
| if box.style['direction'] == 'rtl': |
There was a problem hiding this comment.
The logical part here is good. A nice improvement would be to multiply free_space by -1 here if direction is rtl, it would help keeping only one block below instead of duplicating it.
There was a problem hiding this comment.
I have tried to add what you required but it breaks the flex items
| article.position_x + article.width) | ||
| assert div_1.position_x > div_2.position_x > div_3.position_x | ||
|
|
||
|
|
||
| @assert_no_logs |
There was a problem hiding this comment.
Adding tests here with rtl + column is a good idea.
malnajdi
commented
Oct 10, 2020
| @@ -58,7 +58,9 @@ def test_flex_direction_row_rtl(): | |||
| div_2.position_y == | |||
| div_3.position_y == | |||
| article.position_y) | |||
| assert div_1.position_x == article.width - div_1.padding_width() | |||
| assert ( | |||
There was a problem hiding this comment.
@liZe please verify if this test is correct.
| assert ( | ||
| div_3.position_x + div_3.width == | ||
| article.position_x + article.width) | ||
| assert div_3.position_x == article.position_x |
There was a problem hiding this comment.
@liZe please verify if this test is correct.
|
Thanks a lot! No problem, I’ll simplify the "if rtl" part of your PR in a future commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added:
related #601
related #106