Use platform.uname instead of os.uname #1044
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
platform.uname()
should work on all platforms (cf. #1023 (comment)) and thereforeweasyprint --info
, too.Decided to
import platform
locally to avoid unnecessary initialization when there is no--info
argument.It's just educated guessing that it reveals interesting facts on Windows -- I don't have no Windows computer anymore.
Have no idea how to write a unit test for
PrintInfo
action 😳