Don’t crash when fixed elements aren’t displayed yet in aborted line

Fix #1806.
Kozea · Feb 13, 2023 · dc7c2cb · dc7c2cb
1 parent 16cf66c
commit dc7c2cb
Show file tree

Hide file tree

Showing 2 changed files with 99 additions and 2 deletions.
diff --git a/tests/draw/test_absolute.py b/tests/draw/test_absolute.py
@@ -672,3 +672,101 @@ def test_absolute_pages_counter_orphans(assert_pixels):
         </style>
         a a a <div>a a a</div> a <div>a a a</div>
     ''')
+
+
+@assert_no_logs
+def test_absolute_in_inline(assert_pixels):
+    assert_pixels('''
+        ______
+        _GG___
+        _GG___
+        _GG___
+        _GG___
+        ______
+        ______
+        ______
+        ______
+
+        ______
+        _RR___
+        _RR___
+        _RR___
+        _RR___
+        _BB___
+        _BB___
+        ______
+        ______
+    ''', '''
+        <style>
+            @font-face {src: url(weasyprint.otf); font-family: weasyprint}
+            @page {
+                margin: 1px;
+                size: 6px 9px;
+            }
+            body {
+                color: red;
+                font-family: weasyprint;
+                font-size: 2px;
+                line-height: 1;
+                orphans: 2;
+                widows: 2;
+            }
+            p {
+                color: lime;
+            }
+            div {
+                color: blue;
+                position: absolute;
+            }
+        </style>
+        <p>a a</p> a a <div>a</div>
+    ''')
+
+
+@assert_no_logs
+def test_fixed_in_inline(assert_pixels):
+    assert_pixels('''
+        ______
+        _GG___
+        _GG___
+        _GG___
+        _GG___
+        _BB___
+        _BB___
+        ______
+        ______
+
+        ______
+        _RR___
+        _RR___
+        _RR___
+        _RR___
+        _BB___
+        _BB___
+        ______
+        ______
+    ''', '''
+        <style>
+            @font-face {src: url(weasyprint.otf); font-family: weasyprint}
+            @page {
+                margin: 1px;
+                size: 6px 9px;
+            }
+            body {
+                color: red;
+                font-family: weasyprint;
+                font-size: 2px;
+                line-height: 1;
+                orphans: 2;
+                widows: 2;
+            }
+            p {
+                color: lime;
+            }
+            div {
+                color: blue;
+                position: fixed;
+            }
+        </style>
+        <p>a a</p> a a <div>a</div>
+    ''')
diff --git a/weasyprint/layout/block.py b/weasyprint/layout/block.py
@@ -1032,9 +1032,8 @@ def remove_placeholders(context, box_list, absolute_boxes, fixed_boxes):
             remove_placeholders(
                 context, box.children, absolute_boxes, fixed_boxes)
         if box.style['position'] == 'absolute' and box in absolute_boxes:
-            # box is not in absolute_boxes if its parent has position: relative
             absolute_boxes.remove(box)
-        elif box.style['position'] == 'fixed':
+        elif box.style['position'] == 'fixed' and box in fixed_boxes:
             fixed_boxes.remove(box)
         if box.footnote:
             context.unlayout_footnote(box.footnote)