Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add value class support to the ProtoBufSchemaGenerator #2542

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Add value class support to the ProtoBufSchemaGenerator #2542

merged 1 commit into from
Jan 12, 2024

Conversation

rotilho
Copy link
Contributor

@rotilho rotilho commented Jan 11, 2024

Closes #2089

shanshin
shanshin previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@shanshin shanshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts!

@shanshin shanshin changed the base branch from master to dev January 12, 2024 12:44
@shanshin shanshin changed the base branch from dev to master January 12, 2024 12:46
@shanshin
Copy link
Contributor

shanshin commented Jan 12, 2024 •
edited
Loading

@rotilho, could you please rebase your changes over the dev branch?
PR should also be into the dev branch.

@shanshin shanshin self-requested a review January 12, 2024 13:48
@rotilho rotilho changed the base branch from master to dev January 12, 2024 15:02
@rotilho
Copy link
Contributor Author

rotilho commented Jan 12, 2024

@shanshin done!

@shanshin
Copy link
Contributor

Thanks!

@shanshin shanshin merged commit b3f6e0f into Kotlin:dev Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshin shanshin shanshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating ProtoBuf schema using UInt fails
2 participants
@rotilho @shanshin