Support decoding maps with boolean keys #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ignore quoted/unquoted state when decoding maps with number keys, so it is logical to do the same for boolean maps. Fixes #2438
qwwdfsad
approved these changes
Sep 14, 2023
sandwwraith
added a commit
that referenced
this pull request
Feb 12, 2024
Because after #2440 quoted boolean values are allowed by default, and quoted numbers were allowed even before that.
sandwwraith
added a commit
that referenced
this pull request
Feb 16, 2024
Because after #2440 quoted boolean values are allowed by default, and quoted numbers were allowed even before that.
rewgoes
reviewed
Jul 24, 2024
Comment on lines
+271
to
277
| /* | ||
| * The primitives are allowed to be quoted and unquoted | ||
| * to simplify map key parsing and integrations with third-party API. | ||
| */ | ||
| override fun decodeBoolean(): Boolean { | ||
| /* | ||
| * We prohibit any boolean literal that is not strictly 'true' or 'false' as it is considered way too | ||
| * error-prone, but allow quoted literal in relaxed mode for booleans. | ||
| */ | ||
| return if (configuration.isLenient) { | ||
| lexer.consumeBooleanLenient() | ||
| } else { | ||
| lexer.consumeBoolean() | ||
| } | ||
| return lexer.consumeBooleanLenient() | ||
| } |
There was a problem hiding this comment.
@sandwwraith and @qwwdfsad, I think this goes against RFC-4627.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ignore quoted/unquoted state when decoding maps with number keys, so it is logical to do the same for boolean maps.
Fixes #2438