Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Serializer for Nothing on the JS target #2330

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Support Serializer for Nothing on the JS target #2330

merged 4 commits into from
Jul 12, 2023

Commits on Jun 12, 2023

  1. Add support for serialization of Nothing on the JS target and add r… 

    …elated tests

`kotlinx.serialization.protobuf.ProtobufNothingTest#testNothing` currently fails on "jsLegacy" and I haven't succeeded in resolving this.
    @ShreckYe
    ShreckYe committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    55d0167 View commit details
    Browse the repository at this point in the history

  2. Quit testing ParameterizedBox<Nothing?> on the JS legacy target bec… 

    …ause generating serializers for parameterized types seems not to work on it
    @ShreckYe
    ShreckYe committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    4319adb View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Improve the tests for Nothing as suggested by @sandwwraith in Kotli… 

    …n#2330
    @ShreckYe
    ShreckYe committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    4b71561 View commit details
    Browse the repository at this point in the history

  2. Add a comment referring to the Kotlin issue as suggested by @sandwwraith 

    

Co-authored-by: Leonid Startsev <[email protected]>
    @ShreckYe @sandwwraith
    ShreckYe and sandwwraith authored Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f130545 View commit details
    Browse the repository at this point in the history