Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NoSuchMethodError when parsing a JSON stream on Java 8 #2328

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Fixed NoSuchMethodError when parsing a JSON stream on Java 8 #2328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39fe976
Fixed NoSuchMethodError when parsing a JSON stream on Java 8
shanshin Jun 12, 2023
a4ecdff
~review fixes
shanshin Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion formats/json/jvmMain/src/kotlinx/serialization/json/internal/CharsetReader.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ internal class CharsetReader(
val remaining = if (position <= limit) limit - position else 0
val bytesRead = inputStream.read(byteBuffer.array(), byteBuffer.arrayOffset() + position, remaining)
if (bytesRead < 0) return bytesRead
byteBuffer.position(position + bytesRead)
// Method `position(I)LByteBuffer` does not exist in Java 8. For details, see comment for `flip` in `init` method
(byteBuffer as Buffer).position(position + bytesRead)
shanshin marked this conversation as resolved.
Show resolved Hide resolved
} finally {
(byteBuffer as Buffer).flip() // see the `init` block in this class for the reasoning behind the cast
}
Expand Down