add functions for creating JsonPrimitives from unsigned numbers #2160
Conversation
| @@ -121,4 +121,54 @@ class JsonPrimitiveSerializerTest : JsonTestBase() { | |||
| assertEquals(string, jvmExpectedString) | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Please also add serialization tests, like JsonUnquotedLiteralTest
There was a problem hiding this comment.
I've added parametrizedTest {}, like in JsonUnquotedLiteralTest
| * The value will be encoded as a JSON number. | ||
| */ | ||
| @ExperimentalSerializationApi | ||
| public fun JsonPrimitive(value: UByte): JsonPrimitive = JsonPrimitive(value.toULong()) |
There was a problem hiding this comment.
The other functions use nullable parameters. I think for unsigned types we should do the same.
There was a problem hiding this comment.
I believe we shouldn't, and nullability for other functions is rather a mistake.
It will cause unnecessary boxing, while bringing no benefit whatsoever: for nullable types, Nothing? overload will be chosen
There was a problem hiding this comment.
I tried adding nullability, but I ran into issues: #2130 (comment)
There was a problem hiding this comment.
@qwwdfsad, shouldn't we leave an explanatory comment so that in the future there will be no questions why a different approach is used?
aSemy
force-pushed
the
feat/json_primitive_unsigned_numbers
branch
from
8188f0c
to
e668b06
Compare
fix #2130
Adds
JsonPrimitive()overloads for constructingJsonPrimitivefrom unsigned numbers