Added support for the kotlin.Nothing class as built-in
#1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdvrieze
reviewed
Jul 18, 2022
sandwwraith
requested changes
Sep 7, 2022
core/commonMain/src/kotlinx/serialization/builtins/BuiltinSerializers.kt
Show resolved
Hide resolved
formats/json-tests/commonTest/src/kotlinx/serialization/SerializersLookupTest.kt
Outdated
Show resolved
Hide resolved
sandwwraith
approved these changes
Sep 16, 2022
|
Waiting for 1.8.0 |
lukellmann
added a commit
to lukellmann/kord
that referenced
this pull request
Nov 20, 2022
It was unused and kotlinx.serialization is going to add NothingSerializer() in the future: Kotlin/kotlinx.serialization#1991
Merged
lukellmann
added a commit
to kordlib/kord
that referenced
this pull request
Nov 26, 2022
This is a collection of miscellaneous small cleanups: * Remove useless @throws annotation It is only meaningful for Java interop, but since Kord is coroutine- based it's not usable from Java anyway. see https://kotlinlang.org/docs/java-to-kotlin-interop.html#checked-exceptions * Update stack trace recovery comments * Make all dev.kord.gateway.Commands public There is no reason that Command.Heartbeat, Identify and Resume were internal. Changing the visibility to public makes them available for things like custom Gateway implementations. * Add missing @KordDsl annotations * Remove NothingSerializer It was unused and kotlinx.serialization is going to add NothingSerializer() in the future: Kotlin/kotlinx.serialization#1991 * Use sealed whens in more places * Deprecate CommandArgument convenience extensions This family of functions has inconsistent behavior (some use casts, other coerce the value) and doesn't have a variant for every ApplicationCommandOptionType. Hope already tried to remove this family of functions before[1], but it was reintroduced[2] because some variants were used in tests. * Rename remaining symbols from int to integer It makes the distinction from kotlin.Int clearer. This has already been done for other symbols in the past (e.g. 37b9155 ). [1] a5bb146 [2] 5f13f84
|
@qwwdfsad Kotlin 1.8.0 is out. Any news about the merge of this PR? |
Co-authored-by: Paul de Vrieze <[email protected]>
sandwwraith
reviewed
Jan 9, 2023
core/commonMain/src/kotlinx/serialization/internal/BuiltInSerializers.kt
Show resolved
Hide resolved
formats/json-tests/commonTest/src/kotlinx/serialization/SerializersLookupTest.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #614
Resolves #932