Add @MetaSerializable annotation #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Jul 4, 2022
| * @see Serializer | ||
| */ | ||
| @Target(AnnotationTarget.ANNOTATION_CLASS) | ||
| //@Retention(AnnotationRetention.RUNTIME) // Runtime is the default retention, also see KT-41082 |
There was a problem hiding this comment.
Does it affect JS IR as well? Is this feature implemented on JS legacy?
There was a problem hiding this comment.
It's supported on all IR backends. JS legacy not supported
There was a problem hiding this comment.
Isn't the problem mentioned here specific only for JS legacy?
There was a problem hiding this comment.
Yes, but this file is compiled for all backends, and JS legacy compiler will issue a lengthy warning
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
qwwdfsad
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.