Incorporate JsonPath into exception messages #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest commit is kinda controversial, it seems like we have to make #1266 finally public for both usage and construction |
qwwdfsad
requested review from
sandwwraith
and removed request for
sandwwraith
qwwdfsad
commented
Jan 24, 2022
formats/json/commonTest/src/kotlinx/serialization/JsonPathTest.kt
Outdated
Show resolved
Hide resolved
sandwwraith
reviewed
Mar 17, 2022
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonPath.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonPath.kt
Show resolved
Hide resolved
JakeWharton
reviewed
Mar 18, 2022
formats/json/commonTest/src/kotlinx/serialization/JsonPathTest.kt
Outdated
Show resolved
Hide resolved
qwwdfsad
force-pushed
the
json-path
branch
2 times, most recently
from
358e1a5
to
85dce74
Compare
sandwwraith
approved these changes
Mar 23, 2022
formats/json/commonTest/src/kotlinx/serialization/JsonPathTest.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While figuring out what to do with polymorphism I've come to the conclusion that #1839 have to be done, otherwise the change is way too widespread and intrusive while being really hard to maintain, so I've reverted this work halfway through and stopped on this