HOCON: parse strings into integers and booleans if possible #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
reviewed
Dec 16, 2021
formats/hocon/src/test/kotlin/kotlinx/serialization/hocon/HoconValuesTest.kt
Outdated
Show resolved
Hide resolved
|
@sandwwraith Thank you for the review. I think I addressed your concerns. |
sandwwraith
approved these changes
Dec 17, 2021
| fun `deserialize map with integers`() { | ||
| val configString = """m = { 2: 1, 4: 3 }""" | ||
| val obj = deserializeConfig(configString, WithMap.serializer()) | ||
| with(obj) { |
| fun `deserialize map with integers as strings`() { | ||
| val configString = """m = { "2": "1", "4":"3" }""" | ||
| val obj = deserializeConfig(configString, WithMap.serializer()) | ||
| with(obj) { |
There was a problem hiding this comment.
👍 sorry for not having checked this thoroughly before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOCON suggest that parsers should apply certain automatic conversions, especially when reading integers/numbers or booleans from strings (1).
This is an attempt to resolve the most pressing issues that would resolve #1439 .
This PR changes parsing so that it now relies on the parsing capabilities for the
Configclass, and not on the obtainedConfigValues.This PR does not claim to cover all automatic conversions mentioned in 1, but is focused on parsing numbers and booleans from strings only.