-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype decodeToSequence to read multiple objects from stream lazily #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hide JsonIterator and provide LazyStreamingMode
sandwwraith
force-pushed
the
json-stream-iterator
branch
from
October 13, 2021 11:55
cc43a5b
to
346e5ad
Compare
sandwwraith
changed the title
Prototype JsonIterator to read multiple objects from stream lazily
Prototype decodeToSequence to read multiple objects from stream lazily
Oct 14, 2021
qwwdfsad
requested changes
Nov 1, 2021
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/JsonIterator.kt
Show resolved
Hide resolved
formats/json/jvmTest/src/kotlinx/serialization/features/JsonStreamFlowTest.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/JsonIterator.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmTest/src/kotlinx/serialization/features/JsonStreamFlowTest.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
pdvrieze
reviewed
Nov 2, 2021
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
qwwdfsad
reviewed
Nov 10, 2021
formats/json/jvmTest/src/kotlinx/serialization/features/JsonStreamFlowTest.kt
Show resolved
Hide resolved
qwwdfsad
approved these changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! 🔥
Please proofread my documentation changes prior to merge
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Vsevolod Tolstopyatov <[email protected]>
sandwwraith
commented
Nov 10, 2021
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/JvmStreams.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Leonid Startsev <[email protected]>
qwwdfsad
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1662