Improve performance of JSON encoding #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
force-pushed
the
json-encoder-perf
branch
from
294b4f2
to
034e121
Compare
|
I suppose it's not really clear where all these improvements came from, so feel free to ask for additional comments, meanwhile, I'll try to document all my finding separately |
sandwwraith
requested changes
Mar 3, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/Composers.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StringOps.kt
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/CharArrayPool.kt
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/JsonStringBuilder.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/JsonStringBuilder.kt
Show resolved
Hide resolved
formats/json/nativeMain/src/kotlinx.serialization.json.internal/JsonStringBuilder.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/JsonStringBuilder.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/JsonStringBuilder.kt
Show resolved
Hide resolved
formats/json/jvmMain/src/kotlinx/serialization/json/internal/CharArrayPool.kt
Show resolved
Hide resolved
sandwwraith
approved these changes
Mar 4, 2021
These perf wins look great! Out of curiosity, how many of the JSON<>String perf wins from 1.2 also apply to JSON<> |
|
@ankushg No, dynamic conversion is a different code part |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements, the same machine, Java 11: