Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@UseSerializers doesn't distinguish between nullable and non-nullable property when choosing KSerializer #984

Closed
edenman opened this issue Aug 17, 2020 · 1 comment · Fixed by JetBrains/kotlin#3906
Closed

@UseSerializers doesn't distinguish between nullable and non-nullable property when choosing KSerializer #984

edenman opened this issue Aug 17, 2020 · 1 comment · Fixed by JetBrains/kotlin#3906
Assignees
@sandwwraith
Labels
bug compiler-plugin Priority: 1

Comments

@edenman
Copy link
Contributor

edenman commented Aug 17, 2020

Describe the bug
If you have a nullable serializer for a type and a non-nullable serializer for a type and you want to register both of them with @UseSerializers, the nullable one is not chosen for nullable properties.

To Reproduce
master...edenman:nullable-and-nonnullable-serializer

Expected behavior
Choose the correct serializer, either by checking the SerialDescriptor or introspecting the type argument on the KSerializer class.

Environment

  • Kotlin version: 1.4.0
  • Library version: 1.0.0-RC
  • Kotlin platforms: common (tested on jvm)
  • Gradle version: 6.3
@edenman edenman mentioned this issue Aug 17, 2020
Closed
@qwwdfsad qwwdfsad assigned qwwdfsad and sandwwraith and unassigned qwwdfsad Aug 24, 2020
shanshin added a commit to JetBrains/kotlin that referenced this issue Nov 6, 2020
@shanshin
Add support of nullable serializers to UseSerializers annotation
7c84138 
Kotlin/kotlinx.serialization#984
@shanshin shanshin mentioned this issue Nov 6, 2020
Merged
shanshin added a commit that referenced this issue Nov 11, 2020
@shanshin
Improved test of supporting of nullable serializer in UserSerializers…
93eb5b1 
… annotation (Fixes #984)
shanshin added a commit to JetBrains/kotlin that referenced this issue Nov 11, 2020
@shanshin
Add support of nullable serializers to UseSerializers annotation
ae2088b 
Fixes Kotlin/kotlinx.serialization#984
This was referenced Nov 11, 2020
Merged
Merged
shanshin added a commit to JetBrains/kotlin that referenced this issue Nov 24, 2020
@shanshin
Add support of nullable serializers to UseSerializers annotation (#3906)
176071b 
Fixes Kotlin/kotlinx.serialization#984
shanshin added a commit that referenced this issue Nov 25, 2020
@shanshin
Improved test of supporting of nullable serializer in UserSerializers…
1c1a92e 
… annotation (Fixes #984)
shanshin added a commit that referenced this issue Dec 23, 2020
@shanshin
Improved test of supporting of nullable serializer in UserSerializers…
e2ebb31 
… annotation (Fixes #984)
sandwwraith pushed a commit that referenced this issue Dec 24, 2020
@shanshin
Improved test of supporting of nullable serializer in UserSerializers…
6357dea 
… annotation (#1195)

Fixes #984
@edenman
Copy link
Contributor Author

edenman commented Jan 31, 2021

Forgot to say: thanks for fixing this @shanshin! Was able to clean up a whole bunch of code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandwwraith sandwwraith

Labels
bug compiler-plugin Priority: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support of nullable serializers to UseSerializers annotation JetBrains/kotlin
3 participants
@edenman @qwwdfsad @sandwwraith