-
Notifications
You must be signed in to change notification settings - Fork 624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested classes in ProtoBuf produce empty array for native release binary #2608
Comments
Thanks for report. It happens for me for both |
just in case: does it make sense additionally run tests in |
Yes, it makes sense. I'll ask Native team additionally of the best way to do so. We are now refactoring our build scripts (#2654), so you'll have to wait with your PR a little bit :) |
okay! Thanks, I will wait for #2654. |
Proposed here: #2608 To run native tests in release mode, separate tasks are created by KGP for additional test runs, f.e macosArm64ReleaseTest or linuxX64ReleaseTest. By default, they will be run also on build, check and allTests tasks, so they should automatically run on TC. Note: with Kotlin 1.9.22 the original issue (#2608) doesn't reproduce nor via running protobuf tests (which contains tests for inner classes, so I haven't added additional test from original issue), nor via running tests in integration-test module (by adding reproducer test there, not included)
Describe the bug
Nested classes in ProtoBuf produce empty array for native release binary.
No such issue with Cbor or with any other target and Native debug binary. (all cases are provided in repository with reproducer)
To Reproduce
Repository with reproducer: https://github.com/whyoleg/kx-serialization-protobuf-reproducer
To reproduce:
./gradlew macosArm64ReleaseTest
or[TARGET_NAME]ReleaseTest
for other targets, or justcheck
to run all tests (to compare behaviour)Expected behavior
Correct serialised value is returned independent to the target or debug/release mode.
Environment
Note: I can create the same issue in Kotlin YT, as most likely the issue is there, but thought it would be better to create it here to keep track and may be introduce some kind of tests in repository.
The text was updated successfully, but these errors were encountered: