Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support trailing commas in Json lenient mode #1812

Closed
qwwdfsad opened this issue Dec 30, 2021 · 1 comment
Closed

Support trailing commas in Json lenient mode #1812

qwwdfsad opened this issue Dec 30, 2021 · 1 comment
Labels
feature json runtime

Comments

@qwwdfsad
Copy link
Member

The original use-case is to parse-out handwritten configuration JSON where the use of trailing commas is just a convenience (e.g. for prettier git diff), but we would also like to hear other use-cases.
@aSemy
Copy link
Contributor

aSemy commented Jan 6, 2022

I think this would also help with JSON5 support #797

@xn32 xn32 mentioned this issue Sep 20, 2022
Closed
@qwwdfsad qwwdfsad mentioned this issue Mar 6, 2023
Closed
sandwwraith added a commit that referenced this issue Oct 17, 2023
@sandwwraith
Add a flag to allow parser to accept trailing commas.
f795440 
This is one of the popular community requests and one of the main reasons people ask for Json5 support.
Implementing this flag separately will allow alleviating large paint points quickly without a need to wait for full Json5 support.

Fixes #1812
Relates to: #797, #2221
@sandwwraith sandwwraith mentioned this issue Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature json runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aSemy @qwwdfsad