Update BlockHound version to be compatible with JDK 17 #3771
Conversation
* Also, exclude integration from docs, it shouldn't be there Fixes #3701
|
Note: it doesn't work with JDK 20+ though |
| @@ -10,6 +10,9 @@ import kotlinx.coroutines.scheduling.* | |||
| import reactor.blockhound.* | |||
| import reactor.blockhound.integration.* | |||
|
|
|||
| /** | |||
| * @suppress | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Seeing this, I began to wonder whether we should document the class instead since it is possible to sidestep the ServiceLoader mechanism with BlockHound and apply the integrations manually, but it looks like nobody actually uses the integration by name (https://github.com/search?q=CoroutinesBlockHoundIntegration&type=code), and it's not expected that the integrations will be documented (https://github.com/reactor/BlockHound/tree/master/agent/src/main/java/reactor/blockhound/integration), so ok.
| @@ -10,6 +10,9 @@ import kotlinx.coroutines.scheduling.* | |||
| import reactor.blockhound.* | |||
| import reactor.blockhound.integration.* | |||
|
|
|||
| /** | |||
| * @suppress | |||
There was a problem hiding this comment.
Seeing this, I began to wonder whether we should document the class instead since it is possible to sidestep the ServiceLoader mechanism with BlockHound and apply the integrations manually, but it looks like nobody actually uses the integration by name (https://github.com/search?q=CoroutinesBlockHoundIntegration&type=code), and it's not expected that the integrations will be documented (https://github.com/reactor/BlockHound/tree/master/agent/src/main/java/reactor/blockhound/integration), so ok.
Fixes #3701