Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dependency of check task on knitCheck task #34

Merged
merged 2 commits into from
Apr 10, 2022

Conversation

thumannw
Copy link
Contributor

@thumannw thumannw commented Feb 1, 2022

Applying the plugin in a plugins block was not possible because the base plugin is applied afterwards in some Gradle versions (even if it was declared before).

This is an alternative solution to #22 which does not apply the base plugin under the hood. In fact, it is not anymore necessary at all to apply the base plugin.

@thumannw thumannw marked this pull request as ready for review February 1, 2022 20:48
src/KnitPlugin.kt Outdated Show resolved Hide resolved
@thumannw thumannw requested a review from qwwdfsad April 9, 2022 15:00
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@qwwdfsad qwwdfsad merged commit 089a2e2 into Kotlin:main Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants