Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement LocalDate.fromEpochDays #214

Merged
merged 4 commits into from
Jun 24, 2022
Merged

Implement LocalDate.fromEpochDays #214

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8a4e47b
Implement LocalDate.fromEpochDays
dkhalanskyjb Jun 1, 2022
8f0e25e
Fixup
dkhalanskyjb Jun 3, 2022
82aff29
Split math.kt into math.kt and dateCalculations.kt
dkhalanskyjb Jun 24, 2022
7aa5c7d
Further increase timeout for JS tests
dkhalanskyjb Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ kotlin {
nodejs {
testTask {
useMocha {
timeout = "5s"
timeout = "30s"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The highest recorded test duration value was 8.6s, so probably 10-15 s should be fine

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I just don't see the point in this timeout at all. Don't understand what it brings to the table. So, I increased it to the point where it will most certainly not bother us. Do you have some ideas about why this limit could be useful? If so, maybe it makes sense to add it to the other targets as well?

}
}
}
Expand Down