KT-71784 Fix classpath for KMP shared source sets #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adam-enko
added
the
runner: Gradle plugin
…dMain, because Dokka doesn't fully support KMP projects with a single Kotlin target
# Conflicts: # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/index.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/navigation.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/-menu-item/-menu-item.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/-menu-item/image-vector.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/-menu-item/index.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/-menu-item/is-important.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/-menu-item/label.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/-menu-item/on-click.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/core/org.dokka.it.android.kmp.core/index.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/material3/index.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/material3/navigation.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/material3/org.dokka.it.android.kmp.material3/-top-app-bar-action.html # dokka-integration-tests/gradle/projects/it-android-compose/expectedData/html/navigation.html
… can be investigated
antohaby
approved these changes
Dec 5, 2024
whyoleg
approved these changes
Dec 5, 2024
dokka-integration-tests/gradle/src/testExampleProjects/kotlin/ExampleProjectsTest.kt
Show resolved
Hide resolved
examples/gradle-v2/kotlin-multiplatform-example/gradle.properties
Outdated
Show resolved
Hide resolved
…perimental Co-authored-by: Oleg Yukhnevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DGP fetches information from KGP to automatically setup the DokkaSourceSets. In KMP projects DGP incorrectly aggregated the classpath for 'parent' source sets (e.g. commonMain) from all children. This sometimes worked, but sometimes failed.
For each KotlinSourceSet (KSS) DGP needs to use all compilations to determine whether they are 'publishable' ('test' source sets are not publishable by default), and the Kotlin target (for example.
DGP needs to use the specific compilations for a KSS to get the exact classpath for Dokka.
This PR makes DGP track all and specific compilations separately.
Fix KT-71784
Fix #3860