-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hack kotlin compiler to not fail when annotation changes it's type from array to non-array #3859
Conversation
…om array to non-array
"Deserialized ArrayValue should have the same number of elements as the original array value: $result" | ||
} | ||
|
||
// TODO: PATCH START |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only change to original file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on what the patch is in KDoc? Where was it copied from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the link to the changes landed into kotlin.git and rephrased KDoc a bit
…ulti-module project
/** | ||
* exposes [Subclass] from another module which has [SubclassOptInRequired] annotation present | ||
*/ | ||
class Usage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test failes when generating documentation for this module second
which depends on first
.
It's not possible to write just a unit test for this, as we need to first compile first
and then generate documentation for second
with binary dependency on first
to reproduce the issue.
Note: to test this, I was manually set version in TestedVersions to 2.1.0-Beta2.
I will prepare separate PR to run integration tests with 2.1.0-Beta2
"Deserialized ArrayValue should have the same number of elements as the original array value: $result" | ||
} | ||
|
||
// TODO: PATCH START |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate on what the patch is in KDoc? Where was it copied from?
Fixes #3851 until update to Kotlin Compiler 2.1