Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: reworked navbar and ToC according to new design (#3668) #3734

Closed
wants to merge 2 commits into from
Closed

feat: reworked navbar and ToC according to new design (#3668) #3734

wants to merge 2 commits into from

Conversation

berezinant
Copy link
Contributor

@berezinant berezinant commented Aug 6, 2024 •
edited
Loading

image

image

@berezinant berezinant mentioned this pull request Aug 6, 2024
Closed
berezinant
berezinant commented Aug 6, 2024
View reviewed changes
...cts/plugin-base/src/main/kotlin/org/jetbrains/dokka/base/renderers/html/htmlPreprocessors.kt
@@ -104,6 +104,12 @@ public class StylesInstaller(private val dokkaContext: DokkaContext) : PageTrans

public object AssetsInstaller : PageTransformer {
private val imagesPages = listOf(
// ui-kit assets
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now there is no way to register all content from the assets directory so we have to register it file by file

@berezinant berezinant requested a review from zoobestik August 22, 2024 06:57
@berezinant berezinant force-pushed the ktl-1564-navbar branch 2 times, most recently from 1af89c3 to 29999ba Compare September 20, 2024 14:55
@whyoleg whyoleg mentioned this pull request Oct 21, 2024
Merged
@berezinant berezinant changed the title feat: reworked navbar according to new design (#3668) feat: reworked navbar and ToC according to new design (#3668) Nov 12, 2024
@berezinant
Copy link
Contributor Author

Closing as duplicate of #3917

@berezinant berezinant closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krutilov krutilov Awaiting requested review from krutilov

@nikpachoo nikpachoo Awaiting requested review from nikpachoo

@zoobestik zoobestik Awaiting requested review from zoobestik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@berezinant