[K2] Process links inside KDoc section #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmishenev
force-pushed
the
vmishenev/3352-Process-links-inside-kdoc-section
branch
from
bbf71d7 to
c337854
Compare
vmishenev
force-pushed
the
vmishenev/3352-Process-links-inside-kdoc-section
branch
from
c337854 to
adbf6b9
Compare
vmishenev
commented
Jan 16, 2024
| @@ -34,7 +34,11 @@ internal fun parseFromKDocTag( | |||
| listOf(kDocTag) + if (kDocTag.canHaveParent() && parseWithChildren) getAllKDocTags(findParent(kDocTag)) else emptyList() | |||
| DocumentationNode( | |||
| allTags.map { tag -> | |||
| val links = tag.allChildren.filterIsInstance<KDocLink>().associate { it.getLinkText() to externalDri(it) } | |||
There was a problem hiding this comment.
It does not collect children of children.
whyoleg
approved these changes
Jan 17, 2024
IgnatBeresnev
approved these changes
Jan 18, 2024
dokka-subprojects/plugin-base/src/test/kotlin/markdown/LinkTest.kt
Outdated
Show resolved
Hide resolved
vmishenev
deleted the
vmishenev/3352-Process-links-inside-kdoc-section
branch
vmishenev
added a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.