Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Dokkatoo #3188

Merged
merged 1 commit into from
Oct 19, 2023
Merged

add Dokkatoo #3188

merged 1 commit into from
Oct 19, 2023

Conversation

aSemy
Copy link
Contributor

@aSemy aSemy commented Sep 22, 2023

Initial draft PR for #3131 that adds Dokkatoo to Dokka

  • replace package dev.adamko.dokkatoo with org.jetbrains.dokka.dokkatoo
  • upgrade JVM version used to run Gradle to 11 (otherwise BCV-MU doesn't work, because it uses a version of Android Gradle Plugin that requires JVM11+)
  • minor build script edits to get the build scripts to load

- replace package `dev.adamko.dokkatoo` with `org.jetbrains.dokka.dokkatoo`
- upgrade JVM version used to run Gradle to 11 (otherwise BCV-MU doesn't work, because it uses a version of Android that requires JVM11+)
- minor build script edits to get the build scripts to load
@IgnatBeresnev IgnatBeresnev self-assigned this Oct 9, 2023
@IgnatBeresnev IgnatBeresnev added this to the Dokka 1.9.20 milestone Oct 12, 2023
@IgnatBeresnev IgnatBeresnev marked this pull request as ready for review October 19, 2023 11:30
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enormous thanks for such a huge contribution and for investing time into making Dokka a better product in general! It's very much appreciated, both by maintainers and community members :)

I'll merge it as is, and we'll make it work in #3174

@IgnatBeresnev IgnatBeresnev merged commit 35d1560 into Kotlin:master Oct 19, 2023
5 of 6 checks passed
@aSemy aSemy deleted the dokkatoo branch November 15, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants