[Structure refactor] add gradle properties to included builds #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the `dokka_version` value is mandatory, even for projects that aren't published. This requirement should be removed later, and ideally a better way of sharing the project version should be implemented.
aSemy
changed the title
IgnatBeresnev
approved these changes
Sep 6, 2023
Comment on lines
+8
to
+11
| org.jetbrains.dokka.javaToolchain.mainCompiler=8 | ||
| org.jetbrains.dokka.javaToolchain.testLauncher=8 | ||
| org.jetbrains.dokka.kotlinLanguageLevel=1.4 | ||
| dokka_integration_test_parallelism=2 |
There was a problem hiding this comment.
Some notes:
- I remember we had some problems with running kotlinx.coroutines under Java 8, but because everything is coupled - a workaround was added to override the launcher version to 11. It looks like now we can set it to 11 here and remove the hack?
- I think
kotlinLanguageLevel=1.4isn't necessary for integration tests, they don't publish any API, so it should be OK remove it? It would somewhat help with writing tests as kotlinx.test has limited API in 1.4 dokka_integration_test_parallelism=2reminded me that I saw this property set indokka-subprojectsas well, and I think it can be removed from there
Already starting to see benefits from separating the configurations :)
There was a problem hiding this comment.
- I remember we had some problems with running kotlinx.coroutines under Java 8, but because everything is coupled - a workaround was added to override the launcher version to 11. It looks like now we can set it to 11 here and remove the hack?
Unfortunately I think that must remain, because all Gradle integration tests still run together.
There are a few options to make it better, and I think one is to use JVM Test Suites, and make a separate suite for each project.
- I think
kotlinLanguageLevel=1.4isn't necessary for integration tests, they don't publish any API, so it should be OK remove it? It would somewhat help with writing tests as kotlinx.test has limited API in 1.4
Yes, I agree!
dokka_integration_test_parallelism=2reminded me that I saw this property set indokka-subprojectsas well, and I think it can be removed from there
Agreed!
|
Finally got back to it. I'll merge the PR into the branch and then address my comment above as a separate commit Thanks once again! |
IgnatBeresnev
merged commit 85d05b2
into
Kotlin:project-structure-refactoring
0 of 6 checks passed
aSemy
deleted the
structure-refactor/add-gradle-properties-to-subprojects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
gradle.propertiesto included buildsThis is because the
dokka_versionvalue is mandatory, even for projects that aren't published.This requirement should be removed later, and ideally a better way of sharing the project version should be implemented.
Depends on