Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kotlinOptions to compilerOptions #2883

Merged
merged 7 commits into from
Mar 8, 2023
Merged

Migrate kotlinOptions to compilerOptions #2883

merged 7 commits into from
Mar 8, 2023

Conversation

Goooler
Copy link
Contributor

@Goooler Goooler commented Feb 22, 2023 •
edited
Loading

@IgnatBeresnev IgnatBeresnev self-requested a review February 22, 2023 14:51
@Goooler Goooler changed the title Configure Kotlin compilation in KotlinCompilationTask Migrate kotlinOptions to compilerOptions Feb 23, 2023
@IgnatBeresnev IgnatBeresnev added the infrastructure Everything related to builds tools, CI configurations and project tooling label Mar 7, 2023
@IgnatBeresnev
Copy link
Member

Thanks! Could you please rebase onto master or merge it in? The configuration part was moved into a convention plugin

IgnatBeresnev
IgnatBeresnev approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@IgnatBeresnev IgnatBeresnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@IgnatBeresnev IgnatBeresnev merged commit 14c05d7 into Kotlin:master Mar 8, 2023
@Goooler Goooler deleted the fix branch March 8, 2023 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfhbd hfhbd hfhbd left review comments

@IgnatBeresnev IgnatBeresnev IgnatBeresnev approved these changes

Assignees
No one assigned
Labels
infrastructure Everything related to builds tools, CI configurations and project tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Goooler @IgnatBeresnev @hfhbd