Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace package name on cover with "Package-level declarations" #2586

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Replace package name on cover with "Package-level declarations" #2586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0271ab
Replace package name on cover with "Package-level declarations"
IgnatBeresnev Jul 25, 2022
90ab115
Fix unit tests
IgnatBeresnev Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/base/src/main/kotlin/translators/documentables/DefaultPageCreator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ open class DefaultPageCreator(

protected open fun contentForPackage(p: DPackage) = contentBuilder.contentFor(p) {
group(kind = ContentKind.Cover) {
cover("Package ${p.name}")
cover("Package-level declarations")
if (contentForDescription(p).isNotEmpty()) {
sourceSetDependentHint(
p.dri,
Expand Down
6 changes: 2 additions & 4 deletions plugins/base/src/main/resources/dokka/styles/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,8 +192,6 @@ html ::-webkit-scrollbar-thumb {
}

.cover > .platform-hinted {
padding-top: 12px;
margin-top: 12px;
Comment on lines -195 to -196
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not even noticable since there's bottom padding from h1.cover already. Makes the page a little bit more compact and grabs less attention

padding-bottom: 12px;
}

Expand Down Expand Up @@ -550,8 +548,8 @@ h1 {


h1.cover {
font-size: 60px;
line-height: 64px;
font-size: 52px;
line-height: 56px;
Comment on lines -553 to +552
Copy link
Member Author

@IgnatBeresnev IgnatBeresnev Jul 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also barely noticable, makes longer names class/fucntion fit a bit better and doesn't grab as much attention compared to the rest of the page.

letter-spacing: -1.5px;
margin-bottom: 0;
padding-bottom: 32px;
Expand Down
4 changes: 2 additions & 2 deletions plugins/base/src/test/kotlin/utils/contentUtils.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ fun ContentMatcherBuilder<*>.propertySignature(
value: String? = null
) {
group {
header { +"Package test" }
header { +"Package-level declarations" }
skipAllNotMatching()
}
group {
Expand Down Expand Up @@ -190,7 +190,7 @@ fun ContentMatcherBuilder<*>.propertySignature(

fun ContentMatcherBuilder<*>.typealiasSignature(name: String, expressionTarget: String) {
group {
header { +"Package test" }
header { +"Package-level declarations" }
skipAllNotMatching()
}
group {
Expand Down