Fixed multiple jvm targets #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Currently I'm busy with other things, but I'll try to return to this PR by the end of this week |
works by: - renaming the tasks to include the target (except for jvm - for some compatibility) - storing/building the api in subdirectories named after the target Note that for single-target projects the names are not changed. Author: Paul de Vrieze <[email protected]>
…or kotlin multi platform projects, just have two collector tasks "apiDump" and "apiCheck" that depend on the platform specific versions. It improves consistency, compatibility and usability.
pdvrieze
force-pushed
the
fixed-multiple-jvm-targets
branch
from
d7a9356 to
ad0bdad
Compare
|
The pull request has been rebased upon 0.7.1 |
qwwdfsad
requested changes
Sep 8, 2021
…droid target. When there is only one jvm/android target, don't create target specific api dirs. A future version could use the extension to make the behaviour configurable.
This should be fixed in the new pull request. |
qwwdfsad
reviewed
Oct 1, 2021
build.gradle.kts
Outdated
| @@ -36,6 +36,9 @@ tasks.register<Test>("functionalTest") { | |||
| } | |||
| tasks.check { dependsOn(tasks["functionalTest"]) } | |||
|
|
|||
| // Hack (from guidance on gradle forums) needed to handle optional plugin dependencies | |||
There was a problem hiding this comment.
Could you please add a link to the source of the suggestion?
There was a problem hiding this comment.
Looking it up, there should actually be a better way: https://docs.gradle.org/current/userguide/test_kit.html#sub:test-kit-automatic-classpath-injection (rather than https://docs.gradle.org/2.14/userguide/test_kit.html?_ga=2.33896865.1010618029.1633210343-1565008009.1633210343#sub:test-kit-classpath-injection). I'll try to use the better way.
…nal dependencies used as classpath for the plugin under test. This is needed for optional dependencies (as used by this plugin) that would normally be found through other applied plugins (testkit isolates the classpath, unlike regular gradle).
|
All three changes have been processed in the latest push. I found a better source for the code, and documented what is happening much better. |
qwwdfsad
approved these changes
Oct 4, 2021
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
Make the plugin work with Kotlin multiplatform for multiple targets: * Rename tasks to include the target (except for the JVM - for backwards compatibility) * Rather than having separate tasks where some use the original name, just have two collector tasks "apiDump" and "apiCheck" that depend on the platform-specific versions. It improves consistency, compatibility, and usability. * Store and build .api files in subdirectories named after the target Author: Paul de Vrieze <[email protected]> Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#62
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
Make the plugin work with Kotlin multiplatform for multiple targets: * Rename tasks to include the target (except for the JVM - for backwards compatibility) * Rather than having separate tasks where some use the original name, just have two collector tasks "apiDump" and "apiCheck" that depend on the platform-specific versions. It improves consistency, compatibility, and usability. * Store and build .api files in subdirectories named after the target Author: Paul de Vrieze <[email protected]> Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#62
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
Make the plugin work with Kotlin multiplatform for multiple targets: * Rename tasks to include the target (except for the JVM - for backwards compatibility) * Rather than having separate tasks where some use the original name, just have two collector tasks "apiDump" and "apiCheck" that depend on the platform-specific versions. It improves consistency, compatibility, and usability. * Store and build .api files in subdirectories named after the target Author: Paul de Vrieze <[email protected]> Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#62
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
Make the plugin work with Kotlin multiplatform for multiple targets: * Rename tasks to include the target (except for the JVM - for backwards compatibility) * Rather than having separate tasks where some use the original name, just have two collector tasks "apiDump" and "apiCheck" that depend on the platform-specific versions. It improves consistency, compatibility, and usability. * Store and build .api files in subdirectories named after the target Author: Paul de Vrieze <[email protected]> Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#62 Moved from Kotlin/binary-compatibility-validator@6a3180b
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
Make the plugin work with Kotlin multiplatform for multiple targets: * Rename tasks to include the target (except for the JVM - for backwards compatibility) * Rather than having separate tasks where some use the original name, just have two collector tasks "apiDump" and "apiCheck" that depend on the platform-specific versions. It improves consistency, compatibility, and usability. * Store and build .api files in subdirectories named after the target Author: Paul de Vrieze <[email protected]> Co-authored-by: Vsevolod Tolstopyatov <[email protected]> Pull request Kotlin/binary-compatibility-validator#62 Moved from Kotlin/binary-compatibility-validator@6a3180b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rework of the multiple-jvm-targets branch that actually works. The testing is "fixed" and the implementation is fixed. Note that this is not 100% compatible with existing projects as it uses target-specific subdirectories (only for multiplatform projects).