Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin 1.6.10, coroutines 1.6 #86

Merged
merged 11 commits into from
Jan 18, 2022
Merged

Kotlin 1.6.10, coroutines 1.6 #86

merged 11 commits into from
Jan 18, 2022

Conversation

hoc081098
Copy link
Member

No description provided.

@hoc081098 hoc081098 changed the title Kotlin 1 6 @hoc081098 kotlin 1.6.10, coroutines 1.6 Dec 25, 2021
@hoc081098 hoc081098 linked an issue Dec 25, 2021 that may be closed by this pull request
Kotlin 1.6.10 #80
Closed
github-actions[bot]
github-actions bot reviewed Dec 25, 2021
View reviewed changes
app/src/test/java/com/hoc/flowmvi/CheckModulesTest.kt Outdated Show resolved Hide resolved
app/src/test/java/com/hoc/flowmvi/CheckModulesTest.kt Outdated Show resolved Hide resolved
data/src/main/java/com/hoc/flowmvi/data/UserRepositoryImpl.kt Outdated Show resolved Hide resolved
data/src/main/java/com/hoc/flowmvi/data/UserRepositoryImpl.kt Outdated Show resolved Hide resolved
data/src/test/java/com/hoc/flowmvi/data/UserRepositoryImplRealAPITest.kt Outdated Show resolved Hide resolved
feature-main/src/test/java/com/hoc/flowmvi/ui/main/MainVMTest.kt Outdated Show resolved Hide resolved
feature-search/src/main/java/com/hoc/flowmvi/ui/search/SearchVM.kt Outdated Show resolved Hide resolved
feature-search/src/test/java/com/hoc/flowmvi/ui/search/SearchVMTest.kt Outdated Show resolved Hide resolved
mvi/mvi-testing/src/main/java/com/hoc/flowmvi/mvi_testing/BaseMviViewModelTest.kt Outdated Show resolved Hide resolved
mvi/mvi-testing/src/main/java/com/hoc/flowmvi/mvi_testing/BaseMviViewModelTest.kt Show resolved Hide resolved
@hoc081098 hoc081098 changed the title @hoc081098 kotlin 1.6.10, coroutines 1.6 Kotlin 1.6.10, coroutines 1.6 Dec 25, 2021
hoc081098 and others added 6 commits December 25, 2021 23:38
@hoc081098 @github-actions
Update app/src/test/java/com/hoc/flowmvi/CheckModulesTest.kt
c0a4df7 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hoc081098 @github-actions
Update app/src/test/java/com/hoc/flowmvi/CheckModulesTest.kt
e8861af 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hoc081098 @github-actions
Update data/src/main/java/com/hoc/flowmvi/data/UserRepositoryImpl.kt
4edab5e 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hoc081098 @github-actions
Update data/src/test/java/com/hoc/flowmvi/data/UserRepositoryImplReal…
85d5c5d 
…APITest.kt

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hoc081098 @github-actions
Update data/src/test/java/com/hoc/flowmvi/data/UserRepositoryImplReal…
4196c20 
…APITest.kt

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hoc081098 @github-actions
Update mvi/mvi-testing/src/main/java/com/hoc/flowmvi/mvi_testing/Base…
86e235c 
…MviViewModelTest.kt

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@hoc081098 hoc081098 added the enhancement New feature or request label Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #86 (14f4c99) into master (692576d) will decrease coverage by 5.28%.
The diff coverage is 1.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #86      +/-   ##
============================================
- Coverage     58.40%   53.12%   -5.29%     
  Complexity       73       73              
============================================
  Files            44       44              
  Lines          1041     1105      +64     
  Branches        107      131      +24     
============================================
- Hits            608      587      -21     
- Misses          422      489      +67     
- Partials         11       29      +18
Impacted Files Coverage Δ
app/src/main/java/com/hoc/flowmvi/App.kt 41.17% <0.00%> (ø)
...om/hoc/flowmvi/mvi_testing/BaseMviViewModelTest.kt 0.00% <0.00%> (ø)
...in/java/com/hoc/flowmvi/data/UserRepositoryImpl.kt 86.90% <100.00%> (-3.58%) ⬇️
...rc/main/java/com/hoc/flowmvi/ui/search/SearchVM.kt 91.30% <100.00%> (-6.53%) ⬇️
...in/src/main/java/com/hoc/flowmvi/ui/main/MainVM.kt 87.32% <0.00%> (-9.86%) ⬇️
...ava/com/hoc/flowmvi/data/mapper/UserErrorMapper.kt 88.88% <0.00%> (-7.41%) ⬇️
...-add/src/main/java/com/hoc/flowmvi/ui/add/AddVM.kt 92.22% <0.00%> (-6.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c9a8a5...14f4c99. Read the comment docs.

@hoc081098 hoc081098 merged commit 1874bba into master Jan 18, 2022
@hoc081098 hoc081098 deleted the kotlin_1_6 branch January 18, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotlin 1.6.10
1 participant
@hoc081098