Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidebar spill in safari #550

Open
wants to merge 1 commit into
base: 1.9.0
Choose a base branch
from

Conversation

rhizoome
Copy link

remove z-index from sidebar CSS

Fixes #549. I haven't seen any negative consequences, but I do not really know why that z-index was there.

@rhizoome
Copy link
Author

this is currently active on: https://publish.1042.ch/

@rhizoome
Copy link
Author

This is not working. I keep looking for a solution.

remove z-index from sidebar CSS
fix: sidebar spill in safari
@rhizoome rhizoome force-pushed the feature/add-new-user-authentication branch 3 times, most recently from 42251c0 to a1432b5 Compare November 28, 2024 03:28
@rhizoome
Copy link
Author

rhizoome commented Nov 28, 2024

ok the new version works, but is visually unpleasant, you can't ease into unsetting the z-index.

@KosmosisDire
Copy link
Owner

Yeah, I see it sorta works. I think there is likely a better solution though. I'll look into it more

@rhizoome rhizoome force-pushed the feature/add-new-user-authentication branch from a1432b5 to a1c3b9a Compare November 28, 2024 08:38
@rhizoome
Copy link
Author

rhizoome commented Nov 28, 2024

I just relearned about ::after, this is much nicer. But not perfect. As you see in my page, the logo gets squished during the transition.

@rhizoome
Copy link
Author

rhizoome commented Nov 28, 2024

Ok the ::after version only works intermittently. I give up. I settled for the ugly version for my webpage.

I can tell you that problem is caused by dynamically inserting content into the sidebar and that z-index also has a role in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants