feat: Added rendering of armor when using the custom first person #134
Conversation
…armors when using the first person custom
…r finishing the tests.
|
I think this would work better as a boolean in the FirstPersonConfiguration class rather than it's own first person mode, since I also plan to add my own first person mode and this would complicate things. (assuming my PR gets merged) |
|
It's not a bad option when I free up a little I do it now I have too much work :") |
|
Welp, I gave up on what I was trying to do... too hard :( |
|
I wanted to make a good way to have vanilla-style first person anims, rather than just rendering the third person model in first person. |
| /** | ||
| * Use the 3rd person player model (only arms/items/shoulder armor) to render accurate first-person perspective | ||
| */ | ||
| THIRD_PERSON_MODEL_SP(true), |
There was a problem hiding this comment.
Is this new enum entry really necessary?
Wouldn't it be better to have the old entry (with updated comment) and use firstPersonConfig to optionally enable armor/shoulder rendering.
|
i'll just push directly to your repo |
|
You should probably add a constructor to the first person configuration class with the original 4 booleans so mods don't break |
|
Hope this gets merged soon, I am almost done updating my API just waiting on these changes |
A new FirstPersonMode has been added which allows the rendering of armors when using the first person custom
I have preferred to do it this way and not add each shoulder separately to FirstPersonConfiguration because I doubt that anyone would be interested in handling the rendering of the shoulder pads separately, this way it will only be visible according to the arms if both are visible their respective armor parts will be shown instead when only one is visible only that one will show its armor.