fix: button submitters now work #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for mrujs canceled. 🔨 Explore the source changes: c56ad92 🔍 Inspect the deploy log: https://app.netlify.com/sites/mrujs/deploys/619c4b8b6a838c000782360e |
KonnorRogers
force-pushed
the
fix/button-and-link-submissions
branch
from
806bdc2 to
84e1707
Compare
KonnorRogers
commented
Nov 23, 2021
| @@ -80,7 +80,7 @@ export const BASE_SELECTORS: QuerySelectorInterface = { | |||
| linkDisableSelector: `a[${disableWith}], a[${disable}]`, | |||
|
|
|||
| // Button onClick disable selector with possible reenable after remote submission | |||
| buttonDisableSelector: `button[${disableWith}], button[${disable}]`, | |||
| buttonDisableSelector: `button[data-remote][${disableWith}], button[data-remote][${disable}]`, | |||
There was a problem hiding this comment.
Aligns off of rails-ujs. Unrelated to this PR.
KonnorRogers
force-pushed
the
fix/button-and-link-submissions
branch
from
84e1707 to
c56ad92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Ready
Related Issue(s)
Fixes a bug where button based submitters would not work.
Additional Notes
Also changes logic for buttons querySelectors, and links no longer stop everything (@DavidColby)