fix(entities): restore Teleport for new entity button only in Konnect app [KHCP-11277] #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… app [KHCP-11277]
…Kong Manager per pr feedback
mptap
force-pushed
the
fix/teleport-new-entity-button-align-book-icon-khcp-11277
branch
from
933997c
to
1aa1fc1
Compare
|
@kaiarrowood I tried implementing with the fallback div method moved outside of the KTable in the last 3 commits but that doesn't work when |
|
As per https://konghq.atlassian.net/browse/KHCP-11277:
Closing this PR as #1425 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/KHCP-11277
Consumed in https://github.com/Kong/konnect-ui-apps/pull/3087
Deploy Preview: https://pr-3087--gateway-manager.cloud-preview.konghq.tech/gateway-manager
This is an easier solution to avoid the Teleport target warning for Kong Manager by not conditionally rendering this for Kong Manager.Context: This PR introduced the regression #1001
where dynamic component usage for Teleport (instead of constantly using a Teleport component) was resulting in the content being always rendered as a div and never a Teleport
(seems dynamic component and Teleport just don’t work well together).
Summary of next steps:
cc: @Leopoldthecoder
Add destination div for the Teleport
<div id="kong-ui-app-page-header-action-button"/>in all of the Kong Manager GM entities.
Disable the Vue warning fix(teleport): not throw warning when teleport is disabled by Leopoldthecoder · Pull Request #9818 · vuejs/core
Thanks @Yi Yang for opening this PR up.
Hopefully we can get this merged soon.
Revert the dynamic component PR #1001.
Close this PR without merging.