Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump/electron-29 #34

Merged
merged 11 commits into from
Apr 4, 2024
Merged

Bump/electron-29 #34

merged 11 commits into from
Apr 4, 2024

Conversation

jackkav
Copy link

@jackkav jackkav commented Mar 25, 2024

had to move setup node until after brew installs because brew was overwriting the node version
also had to solve a c++ macro conflict in every .cc file

jackkav added 6 commits March 25, 2024 11:19

Verified

This commit was signed with the committer’s verified signature.
richardlau Richard Lau
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@2644418). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   93.51%           
==========================================
  Files              ?       44           
  Lines              ?      940           
  Branches           ?       97           
==========================================
  Hits               ?      879           
  Misses             ?       41           
  Partials           ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jackkav added 5 commits April 4, 2024 14:47
@jackkav jackkav merged commit b03383d into develop Apr 4, 2024
7 of 8 checks passed
@jackkav jackkav deleted the bump/electron-29 branch April 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants