This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(client) add option to override ttl #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hishamhm
reviewed
Aug 23, 2018
There was a problem hiding this comment.
Both the PR description and the comment describe the option as "override ttl", so how about calling validTtl as overrideTtl or forceTtl instead?
Also, I'm assuming there's a use case for forcing the TTL. It would be nice to add that to the PR description for future reference.
|
I picked Additionally, regarding the usecase, I referenced the original issue it resolves, but I could repeat it here? |
|
ah, my bad, I missed the referenced issue, sorry. the explanation for the
name is reasonable as well.
…On Thu, Aug 23, 2018, 17:11 Thijs Schreijer ***@***.***> wrote:
I picked validTtl because it is used as the ttl for valid answers (there
are others for errors etc). If we'd call it overrideTtl it wouldn't
explain which answers it would override.
Additionally, valid is the name of the similar nginx option
regarding the usecase, I referenced the original issue it resolves, but I
could repeat it here?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAO_dfJx-tpXbzS9ZbgFXm9V17XiMkwkks5uTwxtgaJpZM4WJ4NI>
.
|
Implements a new option `validTtl` that, if given, overrides the ttl of any valid answer received from the name server. closes #48
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new option
validTtlthat, if given, overrides thettl of any valid answer received from the name server.
closes #48