Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

localhost not treated specially #50

Closed
james-callahan opened this issue Jul 26, 2018 · 1 comment · Fixed by #54
Closed

localhost not treated specially #50

james-callahan opened this issue Jul 26, 2018 · 1 comment · Fixed by #54
Assignees
@Tieske

Comments

@james-callahan
Copy link

I got {"message":"name resolution failed"} from Kong when my upstream had a localhost target.

This seems to be because my /etc/hosts is empty. However it should have worked:

From RFC 6761: Section 6.3.3

Name resolution APIs and libraries SHOULD recognize localhost
names as special and SHOULD always return the IP loopback address
for address queries and negative responses for all other query
types. Name resolution APIs SHOULD NOT send queries for
localhost names to their configured caching DNS server(s).
@Tieske
Copy link
Member

Tieske commented Jul 26, 2018

This seems to be because my /etc/hosts is empty

exactly. Thanks for the report

@Tieske Tieske self-assigned this Jul 30, 2018
Tieske added a commit that referenced this issue Aug 23, 2018
@Tieske
fix(client) always inject localhost
299d01c 
Treat the localhost name special by always injection it, according
to RFC 6761: Section 6.3.3

fixes #50
Tieske added a commit that referenced this issue Aug 23, 2018
@Tieske
fix(client) always inject localhost
691cbe8 
Treat the localhost name special by always injecting it, according
to RFC 6761: Section 6.3.3

fixes #50
@Tieske Tieske mentioned this issue Aug 23, 2018
Merged
Tieske added a commit that referenced this issue Aug 27, 2018
@Tieske
fix(client) always inject localhost
748210e 
Treat the localhost name special by always injecting it, according
to RFC 6761: Section 6.3.3

fixes #50
Tieske added a commit that referenced this issue Aug 27, 2018
@Tieske
fix(client) always inject localhost
ae73c44 
Treat the localhost name special by always injecting it, according
to RFC 6761: Section 6.3.3

fixes #50
@james-callahan james-callahan mentioned this issue Dec 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tieske Tieske

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(client) always inject localhost Kong/lua-resty-dns-client
2 participants
@Tieske @james-callahan