Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: negotiate Docker API version #932

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jan 22, 2024

When a Docker daemon doesn't support an API version that's used by the Go client, it will reject communication as in the issue we've faced in KIC. This change is to avoid such errors by making sure that the client downgrades the API automatically in case the daemon doesn't support the newest one.

Should unblock #931.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (42eebf1) 60.18% compared to head (6f7e244) 60.49%.
Report is 12 commits behind head on main.

Files Patch % Lines
pkg/utils/docker/client.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
+ Coverage   60.18%   60.49%   +0.30%     
==========================================
  Files          49       50       +1     
  Lines        4024     4032       +8     
==========================================
+ Hits         2422     2439      +17     
+ Misses       1298     1290       -8     
+ Partials      304      303       -1     
Flag Coverage Δ
integration-test 60.49% <76.92%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo merged commit 01c2d1a into main Jan 22, 2024
41 checks passed
@czeslavo czeslavo deleted the fix/negotiate-docker-api branch January 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants