Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IPv6-only clusters #752

Merged
merged 3 commits into from
Oct 4, 2023
Merged

feat: add IPv6-only clusters #752

merged 3 commits into from
Oct 4, 2023

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jul 22, 2023

Support spawning KIND as IPv6 only.

No planned GKE support for this at present. It looks like GKE can now do IPv6, but setting it up requires building a VPC? It's something more complicated than just a cluster setup toggle.

Adds IPv6 support for metallb and kong plugins. The latter requires chart 2.27+, but doesn't bump requirements for non-IPv6 functionality.

I'm not entirely sure what the intent of the old metallb range selection was, since it apparently just chose a static set of arbitrary start and end IPs within the upper 2/3 of a /24. The test netmask was also non-canonical, which causes weirdness. I think the new approach of choosing the actual upper half of the given network is close enough.

@rainest rainest temporarily deployed to gcloud July 22, 2023 00:01 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 22, 2023 00:01 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 22, 2023 00:01 — with GitHub Actions Inactive
@rainest rainest force-pushed the feat/v6-only branch 2 times, most recently from 3ec3084 to 9794ebe Compare July 27, 2023 20:47
@rainest rainest temporarily deployed to gcloud July 27, 2023 20:47 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 27, 2023 20:47 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 27, 2023 20:47 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.22% ⚠️

Comparison is base (6843767) 59.98% compared to head (9c91048) 59.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   59.98%   59.77%   -0.22%     
==========================================
  Files          48       48              
  Lines        3914     3983      +69     
==========================================
+ Hits         2348     2381      +33     
- Misses       1272     1300      +28     
- Partials      294      302       +8     
Flag Coverage Δ
integration-test 59.77% <70.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/utils/networking/networking.go 0.00% <ø> (-100.00%) ⬇️
pkg/clusters/types/kind/utils.go 45.21% <42.30%> (-0.86%) ⬇️
pkg/utils/docker/docker.go 55.00% <57.14%> (+5.00%) ⬆️
pkg/environments/builder.go 51.23% <66.66%> (+1.23%) ⬆️
pkg/clusters/types/kind/builder.go 70.23% <75.00%> (+0.79%) ⬆️
pkg/clusters/addons/kong/addon.go 60.31% <100.00%> (+0.80%) ⬆️
pkg/clusters/addons/metallb/metallb.go 68.93% <100.00%> (+1.23%) ⬆️
pkg/clusters/types/kind/cluster.go 71.25% <100.00%> (+0.73%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainest rainest temporarily deployed to gcloud July 27, 2023 21:32 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 27, 2023 21:32 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 27, 2023 21:32 — with GitHub Actions Inactive
@rainest rainest marked this pull request as ready for review July 27, 2023 21:45
@rainest rainest requested review from a team and shaneutt as code owners July 27, 2023 21:45
@rainest rainest marked this pull request as draft July 27, 2023 21:45
@rainest rainest temporarily deployed to gcloud July 29, 2023 01:12 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 29, 2023 01:12 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud July 29, 2023 01:12 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud September 12, 2023 19:59 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud September 12, 2023 19:59 — with GitHub Actions Inactive
@rainest rainest temporarily deployed to gcloud September 12, 2023 19:59 — with GitHub Actions Inactive
@rainest rainest marked this pull request as ready for review September 12, 2023 20:11
test/integration/ipv6_test.go Show resolved Hide resolved
@rainest rainest merged commit 0dab647 into main Oct 4, 2023
@rainest rainest deleted the feat/v6-only branch October 4, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants