-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add IPv6-only clusters #752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
rainest
force-pushed
the
feat/v6-only
branch
2 times, most recently
from
July 27, 2023 20:47
3ec3084
to
9794ebe
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 59.98% 59.77% -0.22%
==========================================
Files 48 48
Lines 3914 3983 +69
==========================================
+ Hits 2348 2381 +33
- Misses 1272 1300 +28
- Partials 294 302 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
rainest
force-pushed
the
feat/v6-only
branch
from
September 12, 2023 19:28
d83992e
to
4286a6c
Compare
rainest
force-pushed
the
feat/v6-only
branch
from
September 12, 2023 19:55
4286a6c
to
5532bcf
Compare
rainest
force-pushed
the
feat/v6-only
branch
from
September 12, 2023 19:58
5532bcf
to
9c91048
Compare
czeslavo
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support spawning KIND as IPv6 only.
No planned GKE support for this at present. It looks like GKE can now do IPv6, but setting it up requires building a VPC? It's something more complicated than just a cluster setup toggle.
Adds IPv6 support for metallb and kong plugins. The latter requires chart 2.27+, but doesn't bump requirements for non-IPv6 functionality.
I'm not entirely sure what the intent of the old metallb range selection was, since it apparently just chose a static set of arbitrary start and end IPs within the upper 2/3 of a /24. The test netmask was also non-canonical, which causes weirdness. I think the new approach of choosing the actual upper half of the given network is close enough.