Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(db/schema/routes): check schema for flavor traditional_compatible #9987

Merged
merged 35 commits into from
Jan 10, 2023
Merged

chore(db/schema/routes): check schema for flavor traditional_compatible #9987

merged 35 commits into from
Jan 10, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 22, 2022 •
edited
Loading

Summary

Checklist

  • The Pull Request has tests
  • There's an entry in the CHANGELOG

Full changelog

  • rename _get_expression to get_expression
  • add run_with_missing_fields in metaschema.lua
  • check arg.run_with_missing_fields in run_entity_check
  • check field paths and generate expression for flavor traditional_compatible
  • add test case for run_with_missing_fields

@chronolaw chronolaw force-pushed the chore/validate_regex_path_string branch from 7abeffc to 179adef Compare December 22, 2022 07:01
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 22, 2022
@chronolaw chronolaw closed this Dec 26, 2022
@chronolaw chronolaw reopened this Dec 28, 2022
@chronolaw chronolaw temporarily deployed to release December 28, 2022 02:18 — with GitHub Actions Inactive
@chronolaw chronolaw temporarily deployed to release December 28, 2022 02:19 — with GitHub Actions Inactive
@chronolaw chronolaw temporarily deployed to release December 28, 2022 03:24 — with GitHub Actions Inactive
@chronolaw chronolaw temporarily deployed to release December 28, 2022 03:32 — with GitHub Actions Inactive
@chronolaw chronolaw marked this pull request as ready for review December 28, 2022 08:13
@chronolaw chronolaw force-pushed the chore/validate_regex_path_string branch from ca1aed6 to 48aa8f8 Compare December 28, 2022 08:40
@chronolaw chronolaw changed the title chore(db/routes): check schema for flavor traditional_compatible chore(db/schema/routes): check schema for flavor traditional_compatible Jan 4, 2023
dndx
dndx reviewed Jan 9, 2023
View reviewed changes
kong/db/schema/entities/routes.lua Outdated Show resolved Hide resolved
kong/db/schema/init.lua Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 9, 2023
@chronolaw chronolaw mentioned this pull request Jan 9, 2023
Closed
@dndx dndx force-pushed the chore/validate_regex_path_string branch from 9bdf9b8 to 0a3b203 Compare January 10, 2023 06:33
@dndx dndx merged commit 6482493 into master Jan 10, 2023
@dndx dndx deleted the chore/validate_regex_path_string branch January 10, 2023 07:04
@chronolaw chronolaw mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndx dndx dndx approved these changes

Assignees
No one assigned
Labels
changelog core/db schema-change-noteworthy size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chronolaw @dndx