fix(clustering): race cond for new DP and new cfg #9616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarlightIbuki
commented
Oct 26, 2022
StarlightIbuki
requested review from
javierguerragiraldez,
chronolaw and
fffonion
chronolaw
reviewed
Oct 26, 2022
StarlightIbuki
commented
Oct 26, 2022
StarlightIbuki
commented
Oct 26, 2022
chronolaw
approved these changes
Oct 26, 2022
flrgh
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
👍 LGTM, thanks @StarlightIbuki! I have tested locally and can no longer reproduce the bug.
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
push_config_loopskips handling of the new config signal, expect the config to be sent by logic no.1This causes races when a new config comes in while the first DP is receiving its first config, and the config will be skipped as the list is empty. The new config won't be seen by that DP or any new DPs.
We fix that by re-posting the semaphore, so no config will be missed.
Co-authored-by: @flrgh for his diagnosis(don't forget to add this to the commit message)
fix FT-3496