Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(plugins) cache domains_matcher for ACME #9048

Merged
merged 4 commits into from
Jul 6, 2022
Merged

perf(plugins) cache domains_matcher for ACME #9048

merged 4 commits into from
Jul 6, 2022

Conversation

StarlightIbuki
Copy link
Contributor

Update domains_matcher only when ACME's config is updated.

@StarlightIbuki StarlightIbuki requested a review from a team as a code owner July 4, 2022 03:43
@StarlightIbuki StarlightIbuki force-pushed the perf/acme_cache branch 2 times, most recently from 6d1b835 to 05c5593 Compare July 5, 2022 04:41
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 5, 2022
@StarlightIbuki StarlightIbuki force-pushed the fix/skip_domain_verify branch from 12e1b5b to 2f32d95 Compare July 5, 2022 05:55
Base automatically changed from fix/skip_domain_verify to master July 5, 2022 06:02
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 5, 2022
@pull-request-size pull-request-size bot added size/M and removed size/L labels Jul 5, 2022
@StarlightIbuki StarlightIbuki changed the title feat(plugins) cache domains_matcher for ACME perf(plugins) cache domains_matcher for ACME Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

🚀 Performance test result

Test Suite: 01-rps 02-flamegraph (baseline,single_route,simple)

["Imgur Images","Imgur Images","Imgur Images"]

Click to expand 
Please see Github Actions artifacts for flamegraphs.

  ### Result for upstream directly (run 1):
Running 30s test @ http://10.67.35.139:8088/test
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   562.15us    1.25ms  12.13ms   87.20%
    Req/Sec   173.68k    11.91k  226.74k    71.55%
  25938179 requests in 30.10s, 3.38GB read
Requests/sec: 861758.17
Transfer/sec:    115.06MB
### Result for upstream directly (run 2):
Running 30s test @ http://10.67.35.139:8088/test
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   567.66us    1.25ms  16.05ms   87.24%
    Req/Sec   159.78k     8.90k  212.43k    74.02%
  23859595 requests in 30.10s, 3.11GB read
Requests/sec: 792681.21
Transfer/sec:    105.83MB
### Result for upstream directly (run 3):
Running 30s test @ http://10.67.35.139:8088/test
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency   573.77us    1.26ms  24.07ms   87.29%
    Req/Sec   159.61k     8.86k  209.54k    74.02%
  23839047 requests in 30.10s, 3.11GB read
Requests/sec: 792015.86
Transfer/sec:    105.75MB
### Combined result for upstream directly:
RPS     Avg: 815485.08
Latency Avg: nanms    Max: nanms
  
### Test Suite: git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 #simple #no_plugins #single_route
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 1):
Running 30s test @ http://10.67.35.137:8000/s1-r1
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.16ms    1.78ms  30.06ms   88.85%
    Req/Sec    31.86k     8.29k   53.91k    62.18%
  4761466 requests in 30.10s, 1.00GB read
Requests/sec: 158190.48
Transfer/sec:     33.94MB
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 2):
Running 30s test @ http://10.67.35.137:8000/s1-r1
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.17ms    1.81ms  30.90ms   88.31%
    Req/Sec    32.24k     8.34k   59.92k    59.79%
  4817734 requests in 30.10s, 1.01GB read
Requests/sec: 160058.63
Transfer/sec:     34.34MB
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 3):
Running 30s test @ http://10.67.35.137:8000/s1-r1
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.17ms    1.84ms  38.87ms   88.57%
    Req/Sec    32.16k     8.31k   52.82k    58.26%
  4805879 requests in 30.10s, 1.01GB read
Requests/sec: 159665.33
Transfer/sec:     34.26MB
### Combined result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0:
RPS     Avg: 159304.81
Latency Avg: 1.17ms    Max: 38.87ms
  
### Test Suite: git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 #simple #no_plugins 10 services each has 10 routes
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 1):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.16ms    1.78ms  33.24ms   89.27%
    Req/Sec    29.91k     7.59k   48.67k    60.20%
  4478946 requests in 30.10s, 0.94GB read
Requests/sec: 148802.65
Transfer/sec:     31.93MB
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 2):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.15ms    1.74ms  26.67ms   88.98%
    Req/Sec    30.22k     7.51k   51.13k    59.72%
  4515879 requests in 30.10s, 0.95GB read
Requests/sec: 150031.76
Transfer/sec:     32.19MB
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 3):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.15ms    1.73ms  30.74ms   89.10%
    Req/Sec    30.09k     7.21k   61.92k    59.23%
  4493365 requests in 30.10s, 0.94GB read
Requests/sec: 149286.11
Transfer/sec:     32.03MB
### Combined result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0:
RPS     Avg: 149373.51
Latency Avg: 1.15ms    Max: 33.24ms
  
### Test Suite: git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 #simple #key-auth 10 services each has 10 routes with key-auth, 100 consumers
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 1):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.21ms    1.90ms  65.01ms   90.81%
    Req/Sec    26.58k     6.37k   46.22k    62.39%
  3981269 requests in 30.10s, 854.27MB read
Requests/sec: 132268.71
Transfer/sec:     28.38MB
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 2):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.21ms    1.79ms  30.08ms   90.44%
    Req/Sec    26.38k     6.44k   45.49k    61.20%
  3949501 requests in 30.10s, 847.46MB read
Requests/sec: 131213.26
Transfer/sec:     28.15MB
### Result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0 (run 3):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.21ms    1.80ms  44.28ms   90.66%
    Req/Sec    26.23k     6.55k   43.53k    61.13%
  3927734 requests in 30.10s, 842.79MB read
Requests/sec: 130490.11
Transfer/sec:     28.00MB
### Combined result for Kong git:add389b111308aabd5185de5ebc15a4ab4ee0ce0:
RPS     Avg: 131324.03
Latency Avg: 1.21ms    Max: 65.01ms
  
### Test Suite: git:master #simple #no_plugins #single_route
### Result for Kong git:master (run 1):
Running 30s test @ http://10.67.35.137:8000/s1-r1
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.16ms    1.80ms  29.84ms   88.47%
    Req/Sec    32.09k     8.15k   53.43k    61.98%
  4796284 requests in 30.10s, 1.01GB read
Requests/sec: 159345.95
Transfer/sec:     34.19MB
### Result for Kong git:master (run 2):
Running 30s test @ http://10.67.35.137:8000/s1-r1
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.15ms    1.78ms  30.81ms   88.25%
    Req/Sec    32.25k     8.16k   66.19k    60.23%
  4816327 requests in 30.10s, 1.01GB read
Requests/sec: 160013.54
Transfer/sec:     34.33MB
### Result for Kong git:master (run 3):
Running 30s test @ http://10.67.35.137:8000/s1-r1
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.17ms    1.82ms  30.26ms   88.28%
    Req/Sec    32.14k     8.37k   58.10k    61.45%
  4803652 requests in 30.10s, 1.01GB read
Requests/sec: 159595.14
Transfer/sec:     34.24MB
### Combined result for Kong git:master:
RPS     Avg: 159651.54
Latency Avg: 1.16ms    Max: 30.81ms
  
### Test Suite: git:master #simple #no_plugins 10 services each has 10 routes
### Result for Kong git:master (run 1):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.20ms    1.87ms  32.03ms   89.19%
    Req/Sec    29.85k     7.84k   49.67k    58.74%
  4469622 requests in 30.10s, 0.94GB read
Requests/sec: 148492.44
Transfer/sec:     31.86MB
### Result for Kong git:master (run 2):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.16ms    1.78ms  28.87ms   88.69%
    Req/Sec    30.43k     7.46k   49.56k    59.07%
  4557033 requests in 30.10s, 0.95GB read
Requests/sec: 151396.67
Transfer/sec:     32.49MB
### Result for Kong git:master (run 3):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.16ms    1.78ms  30.52ms   88.87%
    Req/Sec    30.30k     7.55k   52.47k    60.25%
  4528214 requests in 30.10s, 0.95GB read
Requests/sec: 150443.37
Transfer/sec:     32.28MB
### Combined result for Kong git:master:
RPS     Avg: 150110.83
Latency Avg: 1.17ms    Max: 32.03ms
  
### Test Suite: git:master #simple #key-auth 10 services each has 10 routes with key-auth, 100 consumers
### Result for Kong git:master (run 1):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.21ms    1.78ms  36.37ms   90.70%
    Req/Sec    25.85k     6.39k   41.06k    62.86%
  3871314 requests in 30.10s, 830.68MB read
Requests/sec: 128615.57
Transfer/sec:     27.60MB
### Result for Kong git:master (run 2):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.19ms    1.74ms  32.23ms   90.56%
    Req/Sec    26.21k     6.34k   43.95k    59.40%
  3924685 requests in 30.10s, 842.13MB read
Requests/sec: 130388.53
Transfer/sec:     27.98MB
### Result for Kong git:master (run 3):
Running 30s test @ http://10.67.35.137:8000/
  5 threads and 100 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     1.20ms    1.76ms  33.08ms   90.78%
    Req/Sec    25.96k     6.39k   43.63k    63.19%
  3886654 requests in 30.10s, 833.97MB read
Requests/sec: 129125.57
Transfer/sec:     27.71MB
### Combined result for Kong git:master:
RPS     Avg: 129376.56
Latency Avg: 1.20ms    Max: 36.37ms
  

Kong error logs are also available in Github Actions artifacts.

Download Artifacts for detailed results and interactive SVG flamegraphs.

@jschmid1 jschmid1 merged commit 6d4bbe0 into master Jul 6, 2022
@StarlightIbuki StarlightIbuki deleted the perf/acme_cache branch July 6, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fffonion fffonion fffonion approved these changes

Assignees
No one assigned
Labels
plugins/acme size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StarlightIbuki @fffonion @jschmid1