Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-lambda) separate aws credential cache in aws-lambda plugin by plugin identifier in config #8907

Merged
merged 2 commits into from
Jun 9, 2022
Merged

feat(aws-lambda) separate aws credential cache in aws-lambda plugin by plugin identifier in config #8907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
086bfa8
feat(aws-lambda) separate aws credential cache in aws-lambda plugin b…
windmgc Jun 6, 2022
b82e966
cache key by target arn
windmgc Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kong/plugins/aws-lambda/handler.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ local kong = kong

local VIA_HEADER = constants.HEADERS.VIA
local VIA_HEADER_VALUE = meta._NAME .. "/" .. meta._VERSION
local IAM_CREDENTIALS_CACHE_KEY = "plugin.aws-lambda.iam_role_temp_creds"
local IAM_CREDENTIALS_CACHE_KEY_PATTERN = "plugin.aws-lambda.iam_role_temp_creds.%s"
local AWS_PORT = 443
local AWS_REGION do
AWS_REGION = os.getenv("AWS_REGION") or os.getenv("AWS_DEFAULT_REGION")
Expand Down Expand Up @@ -264,8 +264,9 @@ function AWSLambdaHandler:access(conf)

if not conf.aws_key then
-- no credentials provided, so try the IAM metadata service
local iam_role_cred_cache_key = fmt(IAM_CREDENTIALS_CACHE_KEY_PATTERN, conf.aws_assume_role_arn or "default")
local iam_role_credentials = kong.cache:get(
IAM_CREDENTIALS_CACHE_KEY,
iam_role_cred_cache_key,
nil,
fetch_aws_credentials,
aws_conf
Expand Down