fix(api patch) allow PATCH to set an unset field #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base_dao `update()` method used the old entity table to build the UPDATE query instead of the one merged with the new parameters. If a field was previously unset, PATCH would then not set it to the new value (because the old entity table did not have the field present). Fix #857
thibaultcha
added
pr/status/needs review
pr/ready (but hold merge)
thibaultcha
added a commit
that referenced
this pull request
Jan 12, 2016
fix(api patch) allow PATCH to set an unset field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base_dao
update()method used the old entity table to build theUPDATE query instead of the one merged with the new parameters. If a
field was previously unset, PATCH would then not set it to the new value
(because the old entity table did not have the field present).
Fix #857