fix(resolver) percent-encode querystring before proxying #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
added
the
pr/ready (but hold merge)
- directly test `resolver.execute()` - adds a stub of `ngx.shared.DICT` for unit testing where `kong.tools.cache` is being used (it requires shm dicts) - tiny refactors for testability - more use cases covered in specs
Percent-encode query args when re-attaching them to the `upstream_uri`. Since `ngx.encode_args` does not perform percent-encoding on various reserved characters, this implements a custom `utils.encode_args` function which uses LuaSocket's `url.encode` function. It tries to mimic the `ngx.encode_uri` behaviour 100%. Ideally, `ngx.encode_args` would proceed to the percent-encoding itself (see openresty/lua-nginx-module#542). This also makes some perf and style changes. Fix #749
Also fix a bunch of style issues.
thibaultcha
force-pushed
the
fix/resolver-query-encoding
branch
from
491233d to
6274cc4
Compare
thibaultcha
added a commit
that referenced
this pull request
Dec 2, 2015
fix(resolver) percent-encode querystring before proxying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Percent-encode query args when re-attaching them to the
upstream_uri.Since
ngx.encode_argsdoes not perform percent-encoding on variousreserved characters, this implements a custom
utils.encode_argsfunction which uses LuaSocket's
url.encodefunction. It tries to mimicthe
ngx.encode_uribehaviour 100%.Ideally,
ngx.encode_argswould proceed to the percent-encoding itself (seeopenresty/lua-nginx-module#542).
This also makes some perf and style changes, as well as implementing better
unit testing for
resolver.execute().Fix #749