feat: migrate keyspace if it doesn't exist. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaultcha
force-pushed
the
feature/startup-migration
branch
from
69bb42a to
b0a9fb3
Compare
thibaultcha
force-pushed
the
feature/startup-migration
branch
2 times, most recently
from
f6fb8c9 to
1190034
Compare
+ test for startup migration feat: CLI outputs nicer startup error messages - Nicer error messages in stdout from init failure - cleanup bin/kong refactor: structure - core renamed 'resolver' - 'resolver' doesn't inherit from Base_plugin anymore (it is not a plugin) - 'resolver' has nicer method names make it clearer to understand what is going on in nginx.conf - kong code is not nested in src/kong anymore, rather directly put under src/
thibaultcha
force-pushed
the
feature/startup-migration
branch
from
1190034 to
031ec56
Compare
thibaultcha
added a commit
that referenced
this pull request
Mar 18, 2015
feat: migrate keyspace if it doesn't exist.
ctranxuan
pushed a commit
to streamdataio/kong
that referenced
this pull request
Aug 25, 2015
feat: migrate keyspace if it doesn't exist.
bungle
added a commit
that referenced
this pull request
Oct 19, 2022
### Summary ### [0.8.13] - 2022-10-14 #### bug fixes - **x509.\*:** fix set_extension will fail when a extension with same NID is not exist yet ([#75](fffonion/lua-resty-openssl#75)) [b2f57b8](fffonion/lua-resty-openssl@b2f57b8) #### features - **x509.altname:** support set and get IP addresses ([#74](fffonion/lua-resty-openssl#74)) [363c80d](fffonion/lua-resty-openssl@363c80d) - **x509.store:** add set_flags ([#77](fffonion/lua-resty-openssl#77)) [8f3f16a](fffonion/lua-resty-openssl@8f3f16a) ### [0.8.11] - 2022-10-12 #### performance improvements - **\*:** reuse cdata to improve performance [fc9cecd](fffonion/lua-resty-openssl@fc9cecd)
bungle
added a commit
that referenced
this pull request
Oct 19, 2022
### Summary ### [0.8.13] - 2022-10-14 #### bug fixes - **x509.\*:** fix set_extension will fail when a extension with same NID is not exist yet ([#75](fffonion/lua-resty-openssl#75)) [b2f57b8](fffonion/lua-resty-openssl@b2f57b8) #### features - **x509.altname:** support set and get IP addresses ([#74](fffonion/lua-resty-openssl#74)) [363c80d](fffonion/lua-resty-openssl@363c80d) - **x509.store:** add set_flags ([#77](fffonion/lua-resty-openssl#77)) [8f3f16a](fffonion/lua-resty-openssl@8f3f16a) ### [0.8.11] - 2022-10-12 #### performance improvements - **\*:** reuse cdata to improve performance [fc9cecd](fffonion/lua-resty-openssl@fc9cecd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to #68:
Instead of doing this in the bash script, we do it in
main.lua'sinit_by_luasince the error handling from bin/kong is already handled.We only run migrations if we detect than they were never ran before. We won't automatically run any new migration because the process shouldn't be transparent, users should know about it and backup their data if they want to.
init_by_lua)