Replacing the previous uuid library with our lua_uuid #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side note: this might also fix #478, assuming the supposed cause of the issue is correct. |
subnetmarco
force-pushed
the
chore/uuid
branch
from
de023e2 to
4e08b10
Compare
subnetmarco
force-pushed
the
chore/uuid
branch
from
bf13b22 to
752ac77
Compare
|
Updated with new version of |
subnetmarco
added
pr/ready (but hold merge)
subnetmarco
added a commit
that referenced
this pull request
Nov 10, 2015
Replacing the previous uuid library with our lua_uuid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces https://github.com/Tieske/uuid with https://github.com/Mashape/lua-uuid.
The previous UUID library seemed to produce UUID conflicts that lead to errors like #659. The new library leverages libuuid which provides a more solid implementation.
When we decide to merge this PR, we need to update https://github.com/Mashape/kong-distributions to include a dependency to libuuid whenever the operating system doesn't already ship with it.