[hotfix/resolver] avoid URL decoding in URI proxying

[subnetmarco]

This should fix issue #688.

@yoanisgil to test this do you need a distribution package? If yes, just tell me your system and I can create it for you.

[yoanisgil]

@thefosk We're on Docker :) so I guess something like mashape/kong:hostfix_uri will work :D

[yoanisgil]

BTW looks like the build system is broke :(

[subnetmarco]

Yes, the TravisCI and CircleCI integrations are not working properly, but it works locally if you execute make test-all. I have done a rewrite to the CLI in the feat/invalidations branch (which includes clustering support), which is going to be my starting point to fix this once and for all.

I am building the docker package, please give me a few minutes.

[subnetmarco]

The Docker image is kong:hotfixuri, you can now execute:

docker run -p 8000:8000 -p 8001:8001 -d --name kong --link cassandra:cassandra mashape/kong:hotfixuri

[yoanisgil]

Thanks ! I'll give a try and let you know. BTW aren't you guys using automated builds from Docker Hub with dynamic branches? That seems a pretty neat though I haven't had the time to test it myself ...

[subnetmarco]

Nope, we are not using automated builds - would be cool to spend some time doing that (also #219).

Let me know if this hotfix addresses the issue.

[yoanisgil]

@thefosk Just wanted to confirm that your fix works. Thanks!!

[yoanisgil]

Just curious, why the split on "?" ?

[subnetmarco]

Some plugins, like the Request Transformations, can update the querystring. Here we are calculating the base URI, and then later in kong.lua after all the "access" handlers in the plugins have been executed, we append the possibly updated querystring at the end. So here, since I just want the base URI for resolving the API using the path, I remove the querystring.

I personally don't like the split on every request, but I can't see how we can do this differently. On the other side the split function should be fast because it invokes stringy, which invokes strchr under the hood.

[subnetmarco]

Manually merged into both master and next

[yoanisgil]

@thefosk Can you please let me know once the new tag is available on Docker Hub?

[subnetmarco]

@yoanisgil it's going to happen in the next version - we will announce it on Gitter and on our blog.